Change in openvpn[master]: Mbed TLS 4: Add more algorithms
A message that is not in the archive (sent off-list or not yet received): gerrit.1769619521000.I740991f22b728fe2f5a48bc18d5ca4b62f56f399@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email
to review the following change.
Change subject: Mbed TLS 4: Add more algorithms
......................................................................
Mbed TLS 4: Add more algorithms
Expand the tables of hash functions and elliptic curve groups, and also check if they are compiled in.
Change-Id: I740991f22b728fe2f5a48bc18d5ca4b62f56f399
---
M src/openvpn/crypto_mbedtls.c
M src/openvpn/ssl_mbedtls.c
2 files changed, 67 insertions(+), 3 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/00/1500/1
src/openvpn/crypto_mbedtls.c +27 -1
@@ -605,10 +605,36 @@ }static const md_info_t md_info_table[] = { -/* TODO: Fill out table. */ +#if defined(PSA_WANT_ALG_MD5) {"MD5" ,PSA_ALG_MD5 }, +#endif +#if defined(PSA_WANT_ALG_SHA_1) {"SHA1" ,PSA_ALG_SHA_1 }, +#endif +#if defined(PSA_WANT_ALG_SHA_224) + {"SHA224" ,PSA_ALG_SHA_224 }, +#endif +#if defined(PSA_WANT_ALG_SHA_256) {"SHA256" ,PSA_ALG_SHA_256 }, +#endif +#if defined(PSA_WANT_ALG_SHA_384) + {"SHA384" ,PSA_ALG_SHA_384 }, +#endif +#if defined(PSA_WANT_ALG_SHA_512) + {"SHA512" ,PSA_ALG_SHA_512 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_224) + {"SHA3-224" ,PSA_ALG_SHA3_224 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_256) + {"SHA3-256" ,PSA_ALG_SHA3_256 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_384) + {"SHA3-384" ,PSA_ALG_SHA3_384 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_512) + {"SHA3-512" ,PSA_ALG_SHA3_512 }, +#endif };const size_t md_info_table_entries =sizeof (md_info_table) /sizeof (md_info_t);
src/openvpn/ssl_mbedtls.c +40 -2
62 lines not on this page · raw message
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I740991f22b728fe2f5a48bc18d5ca4b62f56f399
Gerrit-Change-Number: 1500
Gerrit-PatchSet: 1
Gerrit-Owner: MaxF <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email
to look at the new patch set (#2).
Change subject: Mbed TLS 4: Add more algorithms
......................................................................
Mbed TLS 4: Add more algorithms
Expand the tables of hash functions and elliptic curve groups, and also check if they are compiled in.
---
M src/openvpn/crypto_mbedtls.c
M src/openvpn/ssl_mbedtls.c
2 files changed, 67 insertions(+), 3 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/00/1500/2
src/openvpn/crypto_mbedtls.c +27 -1
@@ -605,10 +605,36 @@ }static const md_info_t md_info_table[] = { -/* TODO: Fill out table. */ +#if defined(PSA_WANT_ALG_MD5) {"MD5" ,PSA_ALG_MD5 }, +#endif +#if defined(PSA_WANT_ALG_SHA_1) {"SHA1" ,PSA_ALG_SHA_1 }, +#endif +#if defined(PSA_WANT_ALG_SHA_224) + {"SHA224" ,PSA_ALG_SHA_224 }, +#endif +#if defined(PSA_WANT_ALG_SHA_256) {"SHA256" ,PSA_ALG_SHA_256 }, +#endif +#if defined(PSA_WANT_ALG_SHA_384) + {"SHA384" ,PSA_ALG_SHA_384 }, +#endif +#if defined(PSA_WANT_ALG_SHA_512) + {"SHA512" ,PSA_ALG_SHA_512 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_224) + {"SHA3-224" ,PSA_ALG_SHA3_224 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_256) + {"SHA3-256" ,PSA_ALG_SHA3_256 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_384) + {"SHA3-384" ,PSA_ALG_SHA3_384 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_512) + {"SHA3-512" ,PSA_ALG_SHA3_512 }, +#endif };const size_t md_info_table_entries =sizeof (md_info_table) /sizeof (md_info_t);
src/openvpn/ssl_mbedtls.c +40 -2
62 lines not on this page · raw message
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I740991f22b728fe2f5a48bc18d5ca4b62f56f399
Gerrit-Change-Number: 1500
Gerrit-PatchSet: 2
Gerrit-Owner: MaxF <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: MaxF.
plaisthos has posted comments on this change by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email )
Change subject: Mbed TLS 4: Add more algorithms
......................................................................
Patch Set 2:
(1 comment)
File src/openvpn/ssl_mbedtls.c:
http://gerrit.openvpn.net/c/openvpn/+/1500/comment/59742ec5_76de359b?usp=email :
PS2, Line 370: /* Curve25519. */
Any reason to not include Curve448?
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I740991f22b728fe2f5a48bc18d5ca4b62f56f399
Gerrit-Change-Number: 1500
Gerrit-PatchSet: 2
Gerrit-Owner: MaxF <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: MaxF <[email protected]...>
Gerrit-Comment-Date: Wed, 28 Jan 2026 18:11:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: MaxF.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email
to look at the new patch set (#3).
Change subject: Mbed TLS 4: Add more algorithms
......................................................................
Mbed TLS 4: Add more algorithms
Expand the tables of hash functions and elliptic curve groups, and also check if they are compiled in.
---
M src/openvpn/crypto_mbedtls.c
M src/openvpn/ssl_mbedtls.c
2 files changed, 72 insertions(+), 3 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/00/1500/3
src/openvpn/crypto_mbedtls.c +27 -1
@@ -605,10 +605,36 @@ }static const md_info_t md_info_table[] = { -/* TODO: Fill out table. */ +#if defined(PSA_WANT_ALG_MD5) {"MD5" ,PSA_ALG_MD5 }, +#endif +#if defined(PSA_WANT_ALG_SHA_1) {"SHA1" ,PSA_ALG_SHA_1 }, +#endif +#if defined(PSA_WANT_ALG_SHA_224) + {"SHA224" ,PSA_ALG_SHA_224 }, +#endif +#if defined(PSA_WANT_ALG_SHA_256) {"SHA256" ,PSA_ALG_SHA_256 }, +#endif +#if defined(PSA_WANT_ALG_SHA_384) + {"SHA384" ,PSA_ALG_SHA_384 }, +#endif +#if defined(PSA_WANT_ALG_SHA_512) + {"SHA512" ,PSA_ALG_SHA_512 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_224) + {"SHA3-224" ,PSA_ALG_SHA3_224 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_256) + {"SHA3-256" ,PSA_ALG_SHA3_256 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_384) + {"SHA3-384" ,PSA_ALG_SHA3_384 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_512) + {"SHA3-512" ,PSA_ALG_SHA3_512 }, +#endif };const size_t md_info_table_entries =sizeof (md_info_table) /sizeof (md_info_t);
src/openvpn/ssl_mbedtls.c +45 -2
67 lines not on this page · raw message
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I740991f22b728fe2f5a48bc18d5ca4b62f56f399
Gerrit-Change-Number: 1500
Gerrit-PatchSet: 3
Gerrit-Owner: MaxF <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: MaxF <[email protected]...>
Attention is currently required from: plaisthos.
MaxF has posted comments on this change by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email )
Change subject: Mbed TLS 4: Add more algorithms
......................................................................
Patch Set 3:
(1 comment)
File src/openvpn/ssl_mbedtls.c:
http://gerrit.openvpn.net/c/openvpn/+/1500/comment/226baf37_e5dc0946?usp=email :
PS2, Line 370: /* Curve25519. */
Quoted 1 line
Any reason to not include Curve448?
Forgetfulness
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I740991f22b728fe2f5a48bc18d5ca4b62f56f399
Gerrit-Change-Number: 1500
Gerrit-PatchSet: 3
Gerrit-Owner: MaxF <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Comment-Date: Thu, 29 Jan 2026 15:43:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]...>
Attention is currently required from: MaxF.
plaisthos has posted comments on this change by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email )
Change subject: Mbed TLS 4: Add more algorithms
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I740991f22b728fe2f5a48bc18d5ca4b62f56f399
Gerrit-Change-Number: 1500
Gerrit-PatchSet: 3
Gerrit-Owner: MaxF <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: MaxF <[email protected]...>
Gerrit-Comment-Date: Thu, 29 Jan 2026 21:50:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
PATCH v3 1/1 Mbed TLS 4: Add more algorithms
In reply to a message not in the archiveFrom: Max Fillinger <[email protected]...>
Expand the tables of hash functions and elliptic curve groups, and also check if they are compiled in.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1500
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1500
This mail reflects revision 3 of this Change.
Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]...>
src/openvpn/crypto_mbedtls.c +27 -1
@@ -605,10 +605,36 @@ }static const md_info_t md_info_table[] = { -/* TODO: Fill out table. */ +#if defined(PSA_WANT_ALG_MD5) {"MD5" ,PSA_ALG_MD5 }, +#endif +#if defined(PSA_WANT_ALG_SHA_1) {"SHA1" ,PSA_ALG_SHA_1 }, +#endif +#if defined(PSA_WANT_ALG_SHA_224) + {"SHA224" ,PSA_ALG_SHA_224 }, +#endif +#if defined(PSA_WANT_ALG_SHA_256) {"SHA256" ,PSA_ALG_SHA_256 }, +#endif +#if defined(PSA_WANT_ALG_SHA_384) + {"SHA384" ,PSA_ALG_SHA_384 }, +#endif +#if defined(PSA_WANT_ALG_SHA_512) + {"SHA512" ,PSA_ALG_SHA_512 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_224) + {"SHA3-224" ,PSA_ALG_SHA3_224 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_256) + {"SHA3-256" ,PSA_ALG_SHA3_256 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_384) + {"SHA3-384" ,PSA_ALG_SHA3_384 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_512) + {"SHA3-512" ,PSA_ALG_SHA3_512 }, +#endif };const size_t md_info_table_entries =sizeof (md_info_table) /sizeof (md_info_t);
src/openvpn/ssl_mbedtls.c +45 -2
67 lines not on this page · raw message
[Openvpn-devel] [PATCH applied] Re: Mbed TLS 4: Add more algorithms
Very isolated, only affects mbedTLS 4 builds, and is useful for better compatibility with existing deployments. Plus it removes 2 TODO comments.
Your patch has been applied to the master branch.
commit 2183eb5d5437df03f74141f35fd548ae481f6b11
Author: Max Fillinger Date: Fri Jan 30 08:11:31 2026 +0100
Mbed TLS 4: Add more algorithms
Signed-off-by: Max Fillinger <[email protected]...>
Acked-by: Arne Schwabe <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1500
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35507.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#4) to the change originally created by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: Mbed TLS 4: Add more algorithms
......................................................................
Mbed TLS 4: Add more algorithms
Expand the tables of hash functions and elliptic curve groups, and also check if they are compiled in.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1500
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35507.html
---
M src/openvpn/crypto_mbedtls.c
M src/openvpn/ssl_mbedtls.c
2 files changed, 72 insertions(+), 3 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/00/1500/4
src/openvpn/crypto_mbedtls.c +27 -1
@@ -605,10 +605,36 @@ }static const md_info_t md_info_table[] = { -/* TODO: Fill out table. */ +#if defined(PSA_WANT_ALG_MD5) {"MD5" ,PSA_ALG_MD5 }, +#endif +#if defined(PSA_WANT_ALG_SHA_1) {"SHA1" ,PSA_ALG_SHA_1 }, +#endif +#if defined(PSA_WANT_ALG_SHA_224) + {"SHA224" ,PSA_ALG_SHA_224 }, +#endif +#if defined(PSA_WANT_ALG_SHA_256) {"SHA256" ,PSA_ALG_SHA_256 }, +#endif +#if defined(PSA_WANT_ALG_SHA_384) + {"SHA384" ,PSA_ALG_SHA_384 }, +#endif +#if defined(PSA_WANT_ALG_SHA_512) + {"SHA512" ,PSA_ALG_SHA_512 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_224) + {"SHA3-224" ,PSA_ALG_SHA3_224 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_256) + {"SHA3-256" ,PSA_ALG_SHA3_256 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_384) + {"SHA3-384" ,PSA_ALG_SHA3_384 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_512) + {"SHA3-512" ,PSA_ALG_SHA3_512 }, +#endif };const size_t md_info_table_entries =sizeof (md_info_table) /sizeof (md_info_t);
src/openvpn/ssl_mbedtls.c +45 -2
67 lines not on this page · raw message
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I740991f22b728fe2f5a48bc18d5ca4b62f56f399
Gerrit-Change-Number: 1500
Gerrit-PatchSet: 4
Gerrit-Owner: MaxF <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email )
Change subject: Mbed TLS 4: Add more algorithms
......................................................................
Mbed TLS 4: Add more algorithms
Expand the tables of hash functions and elliptic curve groups, and also check if they are compiled in.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1500
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35507.html
---
M src/openvpn/crypto_mbedtls.c
M src/openvpn/ssl_mbedtls.c
2 files changed, 72 insertions(+), 3 deletions(-)
src/openvpn/crypto_mbedtls.c +27 -1
@@ -605,10 +605,36 @@ }static const md_info_t md_info_table[] = { -/* TODO: Fill out table. */ +#if defined(PSA_WANT_ALG_MD5) {"MD5" ,PSA_ALG_MD5 }, +#endif +#if defined(PSA_WANT_ALG_SHA_1) {"SHA1" ,PSA_ALG_SHA_1 }, +#endif +#if defined(PSA_WANT_ALG_SHA_224) + {"SHA224" ,PSA_ALG_SHA_224 }, +#endif +#if defined(PSA_WANT_ALG_SHA_256) {"SHA256" ,PSA_ALG_SHA_256 }, +#endif +#if defined(PSA_WANT_ALG_SHA_384) + {"SHA384" ,PSA_ALG_SHA_384 }, +#endif +#if defined(PSA_WANT_ALG_SHA_512) + {"SHA512" ,PSA_ALG_SHA_512 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_224) + {"SHA3-224" ,PSA_ALG_SHA3_224 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_256) + {"SHA3-256" ,PSA_ALG_SHA3_256 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_384) + {"SHA3-384" ,PSA_ALG_SHA3_384 }, +#endif +#if defined(PSA_WANT_ALG_SHA3_512) + {"SHA3-512" ,PSA_ALG_SHA3_512 }, +#endif };const size_t md_info_table_entries =sizeof (md_info_table) /sizeof (md_info_t);
src/openvpn/ssl_mbedtls.c +45 -2
67 lines not on this page · raw message
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1500?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I740991f22b728fe2f5a48bc18d5ca4b62f56f399
Gerrit-Change-Number: 1500
Gerrit-PatchSet: 4
Gerrit-Owner: MaxF <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>